Mercurial > obsidian-remember-file-state

changeset 44:fae202d7b3de

Find changesets by keywords (author, files, the commit message), revision number or hash, or revset expression.
Fix Typescript warnings and errors
author Ludovic Chabant <ludovic@chabant.com>
date Wed, 20 Sep 2023 23:07:48 -0700
parents 7e981d54a055
children 712761e7625b
files src/main.ts
diffstat 1 files changed, 7 insertions(+), 6 deletions(-) [+]
line wrap: on
line diff
--- a/src/main.ts	Wed Sep 20 22:40:25 2023 -0700
+++ b/src/main.ts	Wed Sep 20 23:07:48 2023 -0700
@@ -200,7 +200,7 @@
 				this.registerOnUnloadFile(view); 
 
 				// Also remember which file is opened in which view.
-				const viewId = this.getUniqueViewId(view as ViewWithID);
+				const viewId = this.getUniqueViewId(view as unknown as ViewWithID);
 				if (viewId != undefined) {
 					this._lastOpenFiles[viewId] = view.file.path;
 				}
@@ -261,7 +261,7 @@
 			return;
 		}
 
-		var shouldSuppressThis: bool = this._suppressNextFileOpen;
+		var shouldSuppressThis: boolean = this._suppressNextFileOpen;
 		this._suppressNextFileOpen = false;
 		if (shouldSuppressThis) {
 			console.debug("RememberFileState: not restoring file state because of explicit suppression");
@@ -342,11 +342,12 @@
 		// Save scrolling position (Obsidian API only gives vertical position).
 		const scrollInfo = {top: view.currentMode.getScroll(), left: 0};
 
-		// Save current selection.
+		// Save current selection. CodeMirror returns a JSON object (not a 
+		// JSON string!) when we call toJSON.
 		// If state selection is undefined, we have a legacy editor. Just ignore that part.
 		const cm6editor = view.editor as EditorWithCM6;
 		const stateSelection: EditorSelection = cm6editor.cm.state.selection;
-		const stateSelectionJSON = (stateSelection !== undefined) ? stateSelection.toJSON() : "";
+		const stateSelectionJSON = (stateSelection !== undefined) ? stateSelection.toJSON() : undefined;
 
 		const stateData = {'scrollInfo': scrollInfo, 'selection': stateSelectionJSON};
 
@@ -358,7 +359,7 @@
 		view.currentMode.applyScroll(stateData.scrollInfo.top);
 
 		// Restore last known selection, if any.
-		if (stateData.selection != "") {
+		if (stateData.selection !== undefined) {
 			const cm6editor = view.editor as EditorWithCM6;
 			var transaction = cm6editor.cm.state.update({
 				selection: EditorSelection.fromJSON(stateData.selection)})
@@ -444,7 +445,7 @@
 		const _this = this;
 		tasks.addPromise(
 			_this.rememberAllOpenedFileStates()
-			.then(_this.writeStateDatabase(STATE_DB_PATH)));
+			.then(() => _this.writeStateDatabase(STATE_DB_PATH)));
 	}
 
 	private readonly rememberAllOpenedFileStates = async(): Promise<void> => {