annotate CONTRIBUTING.md @ 254:52be4cf89810

Don't complain when the job gets killed when Vim exits. This happens on Neovim, where the jobs seem to get killed before Vim exits, and so Gutentags has enough time to print a warning.
author Ludovic Chabant <ludovic@chabant.com>
date Sat, 26 Oct 2019 00:40:18 -0700
parents 02a94ff0db57
children
Ignore whitespace changes - Everywhere: Within whitespace: At end of lines:
rev   line source
172
02a94ff0db57 Add CONTRIBUTING file.
Ludovic Chabant <ludovic@chabant.com>
parents:
diff changeset
1
02a94ff0db57 Add CONTRIBUTING file.
Ludovic Chabant <ludovic@chabant.com>
parents:
diff changeset
2 # Contributing
02a94ff0db57 Add CONTRIBUTING file.
Ludovic Chabant <ludovic@chabant.com>
parents:
diff changeset
3
02a94ff0db57 Add CONTRIBUTING file.
Ludovic Chabant <ludovic@chabant.com>
parents:
diff changeset
4 You're thinking of contributing something to one of my projects? Oh my, I'm
02a94ff0db57 Add CONTRIBUTING file.
Ludovic Chabant <ludovic@chabant.com>
parents:
diff changeset
5 quite honoured! Here's what you need to know.
02a94ff0db57 Add CONTRIBUTING file.
Ludovic Chabant <ludovic@chabant.com>
parents:
diff changeset
6
02a94ff0db57 Add CONTRIBUTING file.
Ludovic Chabant <ludovic@chabant.com>
parents:
diff changeset
7
02a94ff0db57 Add CONTRIBUTING file.
Ludovic Chabant <ludovic@chabant.com>
parents:
diff changeset
8 ## Writing
02a94ff0db57 Add CONTRIBUTING file.
Ludovic Chabant <ludovic@chabant.com>
parents:
diff changeset
9
02a94ff0db57 Add CONTRIBUTING file.
Ludovic Chabant <ludovic@chabant.com>
parents:
diff changeset
10 Clone the repository from either [BitBucket][] (if you're into Mercurial) or
02a94ff0db57 Add CONTRIBUTING file.
Ludovic Chabant <ludovic@chabant.com>
parents:
diff changeset
11 [GitHub][] (if you're into Git).
02a94ff0db57 Add CONTRIBUTING file.
Ludovic Chabant <ludovic@chabant.com>
parents:
diff changeset
12
02a94ff0db57 Add CONTRIBUTING file.
Ludovic Chabant <ludovic@chabant.com>
parents:
diff changeset
13 Next, create a branch for your work -- don't work directly on the `defaut` or
02a94ff0db57 Add CONTRIBUTING file.
Ludovic Chabant <ludovic@chabant.com>
parents:
diff changeset
14 `master` branch. Instead, in Mercurial:
02a94ff0db57 Add CONTRIBUTING file.
Ludovic Chabant <ludovic@chabant.com>
parents:
diff changeset
15
02a94ff0db57 Add CONTRIBUTING file.
Ludovic Chabant <ludovic@chabant.com>
parents:
diff changeset
16 $ hg bookmark my-fix
02a94ff0db57 Add CONTRIBUTING file.
Ludovic Chabant <ludovic@chabant.com>
parents:
diff changeset
17
02a94ff0db57 Add CONTRIBUTING file.
Ludovic Chabant <ludovic@chabant.com>
parents:
diff changeset
18 Or, in Git:
02a94ff0db57 Add CONTRIBUTING file.
Ludovic Chabant <ludovic@chabant.com>
parents:
diff changeset
19
02a94ff0db57 Add CONTRIBUTING file.
Ludovic Chabant <ludovic@chabant.com>
parents:
diff changeset
20 $ git checkout -b my-fix master
02a94ff0db57 Add CONTRIBUTING file.
Ludovic Chabant <ludovic@chabant.com>
parents:
diff changeset
21
02a94ff0db57 Add CONTRIBUTING file.
Ludovic Chabant <ludovic@chabant.com>
parents:
diff changeset
22 Make your changes. Don't write anything that's not related to the fix you're
02a94ff0db57 Add CONTRIBUTING file.
Ludovic Chabant <ludovic@chabant.com>
parents:
diff changeset
23 trying to contribute to the project.
02a94ff0db57 Add CONTRIBUTING file.
Ludovic Chabant <ludovic@chabant.com>
parents:
diff changeset
24
02a94ff0db57 Add CONTRIBUTING file.
Ludovic Chabant <ludovic@chabant.com>
parents:
diff changeset
25 Write a simple, concise commit message. Gutentags isn't a big piece of code so
02a94ff0db57 Add CONTRIBUTING file.
Ludovic Chabant <ludovic@chabant.com>
parents:
diff changeset
26 no need for strict message formats, so don't get fancy.
02a94ff0db57 Add CONTRIBUTING file.
Ludovic Chabant <ludovic@chabant.com>
parents:
diff changeset
27
02a94ff0db57 Add CONTRIBUTING file.
Ludovic Chabant <ludovic@chabant.com>
parents:
diff changeset
28
02a94ff0db57 Add CONTRIBUTING file.
Ludovic Chabant <ludovic@chabant.com>
parents:
diff changeset
29 ## Testing
02a94ff0db57 Add CONTRIBUTING file.
Ludovic Chabant <ludovic@chabant.com>
parents:
diff changeset
30
02a94ff0db57 Add CONTRIBUTING file.
Ludovic Chabant <ludovic@chabant.com>
parents:
diff changeset
31 If you can, try and test your changes on multiple platforms -- Ubuntu, MacOS,
02a94ff0db57 Add CONTRIBUTING file.
Ludovic Chabant <ludovic@chabant.com>
parents:
diff changeset
32 and Windows are supposed to be supported.
02a94ff0db57 Add CONTRIBUTING file.
Ludovic Chabant <ludovic@chabant.com>
parents:
diff changeset
33
02a94ff0db57 Add CONTRIBUTING file.
Ludovic Chabant <ludovic@chabant.com>
parents:
diff changeset
34 Also try to test your changes with:
02a94ff0db57 Add CONTRIBUTING file.
Ludovic Chabant <ludovic@chabant.com>
parents:
diff changeset
35
02a94ff0db57 Add CONTRIBUTING file.
Ludovic Chabant <ludovic@chabant.com>
parents:
diff changeset
36 1. `g:gutentags_cache_dir` enabled and disabled.
02a94ff0db57 Add CONTRIBUTING file.
Ludovic Chabant <ludovic@chabant.com>
parents:
diff changeset
37 2. A repository with spaces in its root path.
02a94ff0db57 Add CONTRIBUTING file.
Ludovic Chabant <ludovic@chabant.com>
parents:
diff changeset
38 3. A repository with files and folders that have spaces in them.
02a94ff0db57 Add CONTRIBUTING file.
Ludovic Chabant <ludovic@chabant.com>
parents:
diff changeset
39
02a94ff0db57 Add CONTRIBUTING file.
Ludovic Chabant <ludovic@chabant.com>
parents:
diff changeset
40 If you're on NeoVim, try and test on a "normal" Vim.
02a94ff0db57 Add CONTRIBUTING file.
Ludovic Chabant <ludovic@chabant.com>
parents:
diff changeset
41
02a94ff0db57 Add CONTRIBUTING file.
Ludovic Chabant <ludovic@chabant.com>
parents:
diff changeset
42
02a94ff0db57 Add CONTRIBUTING file.
Ludovic Chabant <ludovic@chabant.com>
parents:
diff changeset
43 ## Pushing
02a94ff0db57 Add CONTRIBUTING file.
Ludovic Chabant <ludovic@chabant.com>
parents:
diff changeset
44
02a94ff0db57 Add CONTRIBUTING file.
Ludovic Chabant <ludovic@chabant.com>
parents:
diff changeset
45 Once everything's fine, go on BitBucket or GitHub (again, depending on your
02a94ff0db57 Add CONTRIBUTING file.
Ludovic Chabant <ludovic@chabant.com>
parents:
diff changeset
46 favorite source control tool) and create a fork if you haven't done so yet. Push
02a94ff0db57 Add CONTRIBUTING file.
Ludovic Chabant <ludovic@chabant.com>
parents:
diff changeset
47 your changes to your fork, and create a pull request. Check the documentation of
02a94ff0db57 Add CONTRIBUTING file.
Ludovic Chabant <ludovic@chabant.com>
parents:
diff changeset
48 either code portal for more information.
02a94ff0db57 Add CONTRIBUTING file.
Ludovic Chabant <ludovic@chabant.com>
parents:
diff changeset
49
02a94ff0db57 Add CONTRIBUTING file.
Ludovic Chabant <ludovic@chabant.com>
parents:
diff changeset
50 Don't worry if you don't see any reply from me for a while. My turn around time
02a94ff0db57 Add CONTRIBUTING file.
Ludovic Chabant <ludovic@chabant.com>
parents:
diff changeset
51 is measured in weeks, sometimes in months. This is normal -- I've got a job,
02a94ff0db57 Add CONTRIBUTING file.
Ludovic Chabant <ludovic@chabant.com>
parents:
diff changeset
52 a family, and open-source hacking is only one of many awesome hobbies I spend my
02a94ff0db57 Add CONTRIBUTING file.
Ludovic Chabant <ludovic@chabant.com>
parents:
diff changeset
53 limited free time on.
02a94ff0db57 Add CONTRIBUTING file.
Ludovic Chabant <ludovic@chabant.com>
parents:
diff changeset
54
02a94ff0db57 Add CONTRIBUTING file.
Ludovic Chabant <ludovic@chabant.com>
parents:
diff changeset
55 That's it for now! And thanks a lot for contributing!
02a94ff0db57 Add CONTRIBUTING file.
Ludovic Chabant <ludovic@chabant.com>
parents:
diff changeset
56
02a94ff0db57 Add CONTRIBUTING file.
Ludovic Chabant <ludovic@chabant.com>
parents:
diff changeset
57
02a94ff0db57 Add CONTRIBUTING file.
Ludovic Chabant <ludovic@chabant.com>
parents:
diff changeset
58 [bitbucket]: https://bitbucket.org/ludovicchabant/vim-gutentags
02a94ff0db57 Add CONTRIBUTING file.
Ludovic Chabant <ludovic@chabant.com>
parents:
diff changeset
59 [github]: https://github.com/ludovicchabant/vim-gutentags
02a94ff0db57 Add CONTRIBUTING file.
Ludovic Chabant <ludovic@chabant.com>
parents:
diff changeset
60