Mercurial > piecrust2
view piecrust/processing/compressors.py @ 215:a47580a0955b
bake: Better error handling for the processing pipeline.
Pipeline jobs now keep track of whether they've seen any errors. This is
aggregated into an overall "success" flag for the processing record. Also, jobs
keep going as long as there's no critical (i.e. internal) failure happening.
Errors raised by processors are also better tracked: the actual processor that
failed, along with the input file, are tracks in the processing record.
The `bake` command returns a failure exit code if processing saw any error.
author | Ludovic Chabant <ludovic@chabant.com> |
---|---|
date | Sat, 31 Jan 2015 17:08:02 -0800 |
parents | cba781477bd0 |
children | d1490028e211 |
line wrap: on
line source
import os import os.path import logging import platform import subprocess from piecrust.processing.base import SimpleFileProcessor logger = logging.getLogger(__name__) class CleanCssProcessor(SimpleFileProcessor): PROCESSOR_NAME = 'cleancss' def __init__(self): super(CleanCssProcessor, self).__init__({'css': 'css'}) self._conf = None def _doProcess(self, in_path, out_path): self._ensureInitialized() args = [self._conf['bin'], '-o', out_path] args += self._conf['options'] args.append(in_path) logger.debug("Cleaning CSS file: %s" % args) # On Windows, we need to run the process in a shell environment # otherwise it looks like `PATH` isn't taken into account. shell = (platform.system() == 'Windows') try: retcode = subprocess.call(args, shell=shell) except FileNotFoundError as ex: logger.error("Tried running CleanCSS processor with command: %s" % args) raise Exception("Error running CleanCSS processor. " "Did you install it?") from ex if retcode != 0: raise Exception("Error occured in CleanCSS. Please check " "log messages above for more information.") return True def _ensureInitialized(self): if self._conf is not None: return self._conf = self.app.config.get('cleancss') or {} self._conf.setdefault('bin', 'cleancss') self._conf.setdefault('options', ['--skip-rebase']) if not isinstance(self._conf['options'], list): raise Exception("The `cleancss/options` configuration setting " "must be an array of arguments.") class UglifyJSProcessor(SimpleFileProcessor): PROCESSOR_NAME = 'uglifyjs' def __init__(self): super(UglifyJSProcessor, self).__init__({'js': 'js'}) self._conf = None def _doProcess(self, in_path, out_path): self._ensureInitialized() args = [self._conf['bin'], in_path, '-o', out_path] args += self._conf['options'] logger.debug("Uglifying JS file: %s" % args) # On Windows, we need to run the process in a shell environment # otherwise it looks like `PATH` isn't taken into account. shell = (platform.system() == 'Windows') try: retcode = subprocess.call(args, shell=shell) except FileNotFoundError as ex: logger.error("Tried running UglifyJS processor with command: %s" % args) raise Exception("Error running UglifyJS processor. " "Did you install it?") from ex if retcode != 0: raise Exception("Error occured in UglifyJS. Please check " "log messages above for more information.") return True def _ensureInitialized(self): if self._conf is not None: return self._conf = self.app.config.get('uglifyjs') or {} self._conf.setdefault('bin', 'uglifyjs') self._conf.setdefault('options', ['--compress']) if not isinstance(self._conf['options'], list): raise Exception("The `uglify/options` configuration setting " "must be an array of arguments.")